Closed
Conversation
ValerianRey
added
package: autojac
cc: refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing this in favor of the more complete PR #298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
_unionis only used inConjunction.__call__, it makes sence to define it inbase.py(whereConjunctionis defined). Further, sincebase.pycontains several classes, it makes sence to make_uniona static method of specifically theConjunctionclass. Lastly, sinceConjunction.__call__is almost a trivial call to_union, it makes sense to have no_unionmethod but to directly compute this union in the__call__method ofConjunction. This is kind of the opposite of a factorization, but it should enhance code readability since it limits the back-and-forth required to understand a piece of code.Do you agree @PierreQuinton?